Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/09/2020 15:50, Dmitry Fedorov wrote:
> Hi,
>
> Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to
> an issue where a device model stub domain doesn't have maptrack entries.
>
> Would it be possible to apply a user defined max_maptrack_frames value
> to dm_config in the same way as for max_grant_frames?
>
> Signed-off-by: Dmitry Fedorov <d.fedorov@xxxxxxxxx>

This looks entirely reasonable.

CC'ing the maintainers for their opinion.

~Andrew

> ---
>  tools/libxl/libxl_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index f2dc5696b9..f044f2566c 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -2292,7 +2292,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc,
> libxl__stub_dm_spawn_state *sdss)
>      dm_config->b_info.target_memkb = dm_config->b_info.max_memkb;
>
>      dm_config->b_info.max_grant_frames =
> guest_config->b_info.max_grant_frames;
> -    dm_config->b_info.max_maptrack_frames = 0;
> +    dm_config->b_info.max_maptrack_frames =
> guest_config->b_info.max_maptrack_frames;
>
>      dm_config->b_info.u.pv.features = "";
>
> -- 
> 2.26.2
>
>