[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools/hotplug/Linux: don't needlessly use non-standard features in vif-{bridge,route}

To: Jan Beulich <jbeulich@xxxxxxxx>
From: Wei Liu <wl@xxxxxxx>
Date: Mon, 7 Sep 2020 14:28:37 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
Delivery-date: Mon, 07 Sep 2020 14:28:49 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Sep 02, 2020 at 08:09:28AM +0200, Jan Beulich wrote:
> We're not after any "fall-through" behavior here. Replace the constructs
> with ones understood by all conforming shells, including older bash
> (problem observed with 3.1.51(1)).
> 
> Fixes: b51715f02bf9 ("tools/hotplug/Linux: remove code duplication in 
> vif-bridge")
> Fixes: 3683290fc0b0 ("tools/hotplug: only attempt to call 'ip route' if there 
> is valid command")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Wei Liu <wl@xxxxxxx>

References:
- [PATCH v2] tools/hotplug/Linux: don't needlessly use non-standard features in vif-{bridge,route}
  - From: Jan Beulich

Prev by Date: Re: [PATCH v4 02/31] tools: drop explicit path specifications for qemu build
Next by Date: Re: [PATCH 2/3] tools/hotplug: Fix dhcpd symlink removal in vif-nat
Previous by thread: Re: [PATCH v2] tools/hotplug/Linux: don't needlessly use non-standard features in vif-{bridge,route}
Next by thread: [PATCH v3.1 1/8] x86: fix compat header generation
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.