[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Golang design session follow-up
- To: Nick Rosbrook <rosbrookn@xxxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Fri, 28 Aug 2020 15:57:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8XV0e3wPh2bGTn5aYk3wIEFr3pnu4fvQz5BBbqwf3I=; b=A+Iq7h6dwP0NjSgffwTkkTKfGYIgLS7H9hZQJmMF+OjHP+Eu4C+5EN+nimCpOTgKPCbFYWKUX4jtd7PFoqqKLU2vEnpkx2NrT8N0s166vyJCPrXyJHEJnTJQFJvsdRM2h2ITF1PlVoV7dXH8rSmgeiHEd0kfyntsJLWCm16Rt1IeIMwPEVyBwzq/6LgWq8dKPtyyTma6p6OMqFQVfGh6T5I7tli2aX6AuH2U9o5C4xivjTHxEa/SNKnzaA+jc6mKDa8rpcrAxyh/nE9Z4eD2746rXbFkZhdKrIE0G3NlVxU7pjx+m266+s3tQEghIP5+Nc/wy5SqtKGKpn2wY2mEKg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iaXR/ynd+8PdKFCQVFsUnWk4QJHrzSbQmdVd0M57FhQwowxsBFNeHLqywSexVU+bRZ0LCJTdQiImnntAgvkh1A92zoBeNSouZsMd2Zw3hawrqQFVErfzGXfwKnTnnmfd0OQeYo3oDlSgnDhk9wrBKs8Fz+u2BZpGborb1lrTHokSsoH5GyWAFOXTns8EGoFosJUKlLMHSZL+u12SnMGAtxezxcT5HvetMxsonL2FCHzyqdylCu/gmwJIdkjOhyIBOCIGhjwD0HWuj/UwmozBHDx/ImDL7+6e3oPldLN91rvkC/PK6ZGIIXsBRSYJBeSdMUnjPv7CobdfnPnItQS88Q==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, "rosbrookn@xxxxxxxxxxxx" <rosbrookn@xxxxxxxxxxxx>
- Delivery-date: Fri, 28 Aug 2020 15:57:54 +0000
- Ironport-sdr: 9i8OQsdRrNhss7IbFu/nu3qRQrf9zXrXSS5Pha2kYp4+xBRD2kmOoTunOVqiYWCM490hFyem5Y kiYcaW3kCtbp02CiPU3TFRUfTGR6UWHAXhjY7Em7Gmut4Xq7Pyc/zAm7gOi9ABZWgCHm4gcH7G qRhBv8OTSqcHK2+Ubu5bcscHUQJRVMD4ymjrIMoQBObAcCa3kefyN2iRnJZssJMEsp601GmpqZ ulNq9lELiTHugyCNcBozPIZt+Z1E+L7vkwc0NPKQPhJsPh1sjsATbYk/vMAXdMEboTBJ3YQ4E5 rTw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWXvbkqZX3isiLZUWTcowoxjQWaKlN6fcA
- Thread-topic: Golang design session follow-up
> On Jul 21, 2020, at 1:35 AM, Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
>
> # Long-term home of the package
>
> Ian: Autogenerated stuff is becoming more annoying.
>
> Delete all the libxl auto-generated stuff from staging & master, and have
> "output branch".
>
> The reason we have these in-tree is that otherwise you can't build *from
> git* if you don't
> have new enough versions of the right tools.
>
> Distribution: Make a repo on xenbits!
So thinking about this:
The first plan I had was to have a script in tools/golang/xenlight (and/or the
Makefile), which would be handed a directory, and would then:
1. Sync static files from tools/golang/xenlight into that directory
2. Run gengotypes.py, having the resulting generated files put into that
directory
3. Run `git diff` in the target directory; if there are any changes, then
automatically run `git commit` to check in the changes.
That way you could just set up a cron job to sync things over on a regular
basis.
Thinking about GPL considerations, however, you’d also want to include
libxl_types.idl and idl.py. And then of course, you should also include a way
to build the generated code from those two.
At which point… would it make sense to just move the package out to its
separate repo entirely? I.e., have actual development happen in the repo which
ends up being cloned in the end?
Obviously there are nice things about having the code in the same repo; but
there’s also something satisfying about being a full downstream.
I was actually thinking it might make sense to put the repo at
https://gitlab.com/xen-project/go-xenlight , to try out that as a development
model.
Any thoughts?
-George
|
