Re: [patch V2 29/46] irqdomain/msi: Allow to override msi_domain_alloc/free_irqs()

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Wed, Aug 26 2020 at 20:06, Marc Zyngier wrote:
> On Wed, 26 Aug 2020 12:16:57 +0100,
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>>  /**
>> - * msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain 
>> associated tp @dev
>> - * @domain: The domain to managing the interrupts
>> + * msi_domain_alloc_irqs - Allocate interrupts from a MSI interrupt domain
>> + * @domain: The domain to allocate from
>>   * @dev:    Pointer to device struct of the device for which the interrupts
>> - *          are free
>> + *          are allocated
>> + * @nvec:   The number of interrupts to allocate
>> + *
>> + * Returns 0 on success or an error code.
>>   */
>> -void msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
>> +int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
>> +                      int nvec)
>> +{
>> +    struct msi_domain_info *info = domain->host_data;
>> +    struct msi_domain_ops *ops = info->ops;
>
> Rework leftovers, I imagine.

Hmm, no. How would it call ops->domain_alloc_irqs() without getting the
ops. I know, that the diff is horrible, but don't blame me for it. diff
sucks at times.

>> +
>> +    return ops->domain_alloc_irqs(domain, dev, nvec);
>> +}
>> +
>> +void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
>>  {
>>      struct msi_desc *desc;
>>  
>> @@ -513,6 +525,20 @@ void msi_domain_free_irqs(struct irq_dom
>>  }
>>  
>>  /**
>> + * __msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain 
>> associated tp @dev
>
> Spurious __.

Yup.

Thanks,

        tglx