Re: [PATCH] xen/events: Use chip data for storing per IRQ XEN data pointer

[Jürgen Groß <jgross@xxxxxxxx>]

On 25.08.20 17:22, Thomas Gleixner wrote:
> XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt
> XEN data pointer which contains XEN specific information.
>
> handler data is meant for interrupt handlers and not for storing irq chip
> specific information as some devices require handler data to store internal
> per interrupt information, e.g. pinctrl/GPIO chained interrupt handlers.
>
> This obviously creates a conflict of interests and crashes the machine
> because the XEN pointer is overwritten by the driver pointer.
>
> As the XEN data is not handler specific it should be stored in
> irqdesc::irq_data::chip_data instead.
>
> A simple sed s/irq_[sg]et_handler_data/irq_[sg]et_chip_data/ cures that.
>
> Reported-by: Roman Shaposhnik <roman@xxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

> ---
> Note: This probably wants a 'Cc: stable@' and a 'Fixes:' tag, but I
> leave that as an exercise to the maintainers how far they want to move
> that back.
Will do. :-)

Thanks for the patch,


Juergen