[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[OSSTEST PATCH 06/12] duration estimator: Fix a warning


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Date: Tue, 25 Aug 2020 12:40:35 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 25 Aug 2020 11:41:15 +0000
  • Ironport-sdr: Gvnj0CSp6Em3Zzjaj5uTubKIe75V6DoY+SaLrnfEwETAWouiVxd3qB+oTgj7mByusc+klmg8Cx QhjN6K3nAfVb7qMvlnG/QBHXLJHrbr7sisTv6VsfsWqKNZh7n9r1DtzHbBEhg4IHpPMDs9od+B ksN3eneoQ9cNqCaIoh//6sz3LR5OP22CupYEITr39PiGNN9PLHmWrccD3h55bO92Ue+hMFShx7 4QTU+qjHz0uEC4lONWxpKnZ2VqP37O7+TinWvlOmE/cctgtG+SY9GH8kr5zzircKrzbcRznSiP eXw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

$onhost can be undef.  Fixes this warning:

Use of uninitialized value $onhost in concatenation (.) or string at 
Osstest/Executive.pm line 1293.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 Osstest/Executive.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 4151aa6c..b3aecfc5 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -1274,7 +1274,8 @@ END
     return sub {
         my ($job, $hostidname, $onhost, $uptoincl_testid) = @_;
 
-       my $memokey = "$job $hostidname $onhost ".($uptoincl_testid//"");
+       my $memokey =
+         "$job $hostidname ".($onhost//"")." ".($uptoincl_testid//"");
        my $memo = $our_memo->{$memokey};
        return @$memo if $memo;
 
-- 
2.20.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.