[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86/vpic: rename irq to pin in vpic_ioport_write


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 20 Aug 2020 17:17:45 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 20 Aug 2020 16:18:23 +0000
  • Ironport-sdr: 9SBZd/f12DNi2X1pe5Qgw6j3PTaY/MP8npqmxdrQ/LmPTwIVeAKkcrNV9tObBI4w6Ba0xTM+jf xRDCOTlaHsRsHJ+WEFEEoi3ZNaPdd4yM74gFCslkuwgaqVT9rGtYyeWaEoOGpBsIRfvw+OUfeG JCVeen7JwdNZcgT3eNXqxEOOprxGKiJ1i1W75K2pUPhCAJmPyAaWLu+ZK9KmjX34Z0eplh04Ii pxoZsw/d29E79kXZ4OmeF/ZeN8VThglfPiHhFmICmn1ddV2Szm3C1TnFvqi5waQHjnlhWG7zDD xfo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20/08/2020 16:34, Roger Pau Monne wrote:
> The irq variable is wrongly named, as it's used to store the pin on
> the 8259 chip, but not the global irq value. While renaming reduce
> it's scope and make it unsigned.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.