[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore


  • To: "paul@xxxxxxx" <paul@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Tue, 4 Aug 2020 12:35:29 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, 'Paul Durrant' <pdurrant@xxxxxxxxxx>, 'Wei Liu' <wl@xxxxxxx>
  • Delivery-date: Tue, 04 Aug 2020 11:35:52 +0000
  • Ironport-sdr: 0ZpsD4Fll3JfMsMxbR53dUoSCU8buiSAMBxphrNHYIjByu7eT1jx4jQgAX17eugdX++O27KyqF gUm/WRXuJXYFN67fZesn0X/E2ZkPZB0n6u4PK5YuP0XQV9Hoywf1xuLhCppliZuqlbTEg/PH+w 8lSq+m+QdIKVtiYYnOOA/3zhY7wTG7/tr4bpkLgVEesaOUUMY1XjPWzvHaTTIeCm808866atZL yp1A168Vjm21p43zgDhU3SZPrYL1rcMs9VokP8bRzs6c6Z7w+Qt29ZIMwPT+xr4H1qH9nQlWKr cAQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Paul Durrant writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to 
inform the frontend via xenstore"):
> > -----Original Message-----
> > From: Ian Jackson <ian.jackson@xxxxxxxxxx>
> > Sent: 04 August 2020 12:14
> > To: Paul Durrant <paul@xxxxxxx>
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Paul Durrant <pdurrant@xxxxxxxxxx>; Wei 
> > Liu <wl@xxxxxxx>
> > Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the 
> > frontend via xenstore
> > 
> > Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to 
> > inform the frontend via
> > xenstore"):
> > > +       XENBUS_PATH="/local/domain/$domid/device/vif/$devid"
> > > +       xenstore_write "$XENBUS_PATH/mtu" ${mtu}
> > 
> > It's surprising to me that this code doesn't have the xenbus path
> > already in some variable.  But I guess from the fact that you've added
> > this code, that it doesn't.
> 
> It is set, but set to the backend path. For safety I guess it's probably best 
> if I use a local in this instance. Can I keep your R-b
> with such a change?

Oh, wow.  I hadn't realised that.  I take back my earlier R-b :-).

Can you please use a different variable name for the frontend path ?

...

Actually.

This shouldn't be in the frontend at all, should it ?  In general the
backend writes to the backend and the frontend to the frontend.

So maybe I need to take back my R-b of
  [PATCH v2 3/4] public/io/netif: specify MTU override node

Sorry for the confusion.  I seem rather undercaffienated today.

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.