[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore
Paul Durrant writes ("RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore"): > > -----Original Message----- > > From: Ian Jackson <ian.jackson@xxxxxxxxxx> > > Sent: 04 August 2020 12:14 > > To: Paul Durrant <paul@xxxxxxx> > > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Paul Durrant <pdurrant@xxxxxxxxxx>; Wei > > Liu <wl@xxxxxxx> > > Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the > > frontend via xenstore > > > > Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to > > inform the frontend via > > xenstore"): > > > + XENBUS_PATH="/local/domain/$domid/device/vif/$devid" > > > + xenstore_write "$XENBUS_PATH/mtu" ${mtu} > > > > It's surprising to me that this code doesn't have the xenbus path > > already in some variable. But I guess from the fact that you've added > > this code, that it doesn't. > > It is set, but set to the backend path. For safety I guess it's probably best > if I use a local in this instance. Can I keep your R-b > with such a change? Oh, wow. I hadn't realised that. I take back my earlier R-b :-). Can you please use a different variable name for the frontend path ? ... Actually. This shouldn't be in the frontend at all, should it ? In general the backend writes to the backend and the frontend to the frontend. So maybe I need to take back my R-b of [PATCH v2 3/4] public/io/netif: specify MTU override node Sorry for the confusion. I seem rather undercaffienated today. Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |