[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RESEND][PATCH v2 1/7] xen/guest_access: Add emacs magics


  • To: Julien Grall <julien@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 31 Jul 2020 13:04:17 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRMB0UR5j8DpixaHREdiqCaJRQTn1wXeZcoLQkXzj7I=; b=Z8m14NpC6SlVKyp6FtbuongFnMaH79E5/J7l2rB+YKYEZDYbTRMkuaRYp+XUK6/CvPHG3/xmFTp2iCobBYzqku5PpMdk6zqj1NchPCRr/McTuNoCKSB92XOj/FOOfmGWVvwghIf5JUJOeNdiAW93b6LOgzigyvcpS8/2ukwVdmETBc6kba6H/3sScNhGjFioNdlxTNRJFZR8iyomAc53xqzH999hzszP5lh2J6Yw199AklJ8vBmiVfBuZMNSz8ipyEvfHY/S4SgoxIuzkMbaWnjx+Qs8iFfnbb1cG6AOvq2T/2fCop5aNLDkfedDRKqplQbEGCD+Br+mLUnd1Z6rLw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NI0VS157I9mAVK8QkcwYAO/Y3Hh8L9hKdD+8x/vp746bQvHSIXhKCD7H6v9k6Sqf0yaxfT/72mTeXL1llC43t4eI8RX/6v1/lcj1KVGDERPGdAcGeugRwOntMOpVspvmC2PzeFtNckRSJAZkEe4KsxT6WKVS18/uCjYUe63eFW/Q7jYO5kTOGwr9f0UUDTjRyTOmzRnFvTEs05ZBYBvEeIwta23mNiZSPCIc0V59xTR6kPVhr8Z4qq0R6Di4COGPR49JB3RMDuAJhgvgnO7ei9PZwCog7uq8z0BZIsCs1EF8LP5yf5wwFElxOvLmt+4vX3TaIE5L8K92fRz21AEYrA==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, nd <nd@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 31 Jul 2020 13:04:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWZp4EjLyFAMhDcEetGvqId62N/akhqPWA
  • Thread-topic: [RESEND][PATCH v2 1/7] xen/guest_access: Add emacs magics


> On 30 Jul 2020, at 20:18, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Add emacs magics for xen/guest_access.h and
> asm-x86/guest_access.h.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Most of file in Xen source code seem to have a white line before the “emacs 
magics”.
If this is something that should be enforced, it should be done here.

If not the change seems ok :-)

> 
> ---
>    Changes in v2:
>        - Remove the word "missing"
> ---
> xen/include/asm-x86/guest_access.h | 8 ++++++++
> xen/include/xen/guest_access.h     | 8 ++++++++
> 2 files changed, 16 insertions(+)
> 
> diff --git a/xen/include/asm-x86/guest_access.h 
> b/xen/include/asm-x86/guest_access.h
> index 2be3577bd340..3ffde205f6a1 100644
> --- a/xen/include/asm-x86/guest_access.h
> +++ b/xen/include/asm-x86/guest_access.h
> @@ -160,3 +160,11 @@
> })
> 
> #endif /* __ASM_X86_GUEST_ACCESS_H__ */
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/guest_access.h b/xen/include/xen/guest_access.h
> index 09989df819ce..ef9aaa3efcfe 100644
> --- a/xen/include/xen/guest_access.h
> +++ b/xen/include/xen/guest_access.h
> @@ -33,3 +33,11 @@ char *safe_copy_string_from_guest(XEN_GUEST_HANDLE(char) 
> u_buf,
>                                   size_t size, size_t max_size);
> 
> #endif /* __XEN_GUEST_ACCESS_H__ */
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> -- 
> 2.17.1
> 
> 


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.