[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RESEND][PATCH v2 2/7] xen/arm: kernel: Re-order the includes
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 31 Jul 2020 12:58:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hV3wLf96RYlKeb8gH691k9VjenLtEmtuxqc/HLtUFyg=; b=M7f6h5KtvRLoaqur0x+/j9OWCQONchIHVo6xB8ARYHeyICK6jlu2z3CU1Co/7uBwSEihu2JET9QeZ8WHeFDQwejRC1kzQaL1JQJJAX0sf4fbfMvPiptfKYL7QGepcf6R2t9xoirv5abnCx+7G/3XkJk/WCFjEqIkcyZRmDs5tGrvp36wR1bBmAqfzoSsAWD/uaIOoqFzeAn/J0owxuwtEQA3ntDE3f0p0H6KzUu1+5Xf6pJGZ4WV9cTt5xKIKy3N8nJFR8Ys6EhKjIVjeEl0lAqdvNaYzcZite7ktQwnG9Xccgy1MG1wMwbvmMnr+e36dR3sI6IDgpL5mwYeARftbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lD4U3oJzEHmRzwmdKgOVr19gF97nFISzqDNH4OwxOx74Xu6w+wfVwegxtjHSr1EmyX35e0xB0OeT4f3QPdV3Bfx3hOYZM9PcLNyt2WniRxVZSFBLdveecCbuZSTGJEdBrNl/ZhOXH/4vaq+x+AZGX+lAPZZ2cUdABaKCRAUqh0/h/pSIbv6HyvdDSKz6rSkoU0zhhVu79TWQx7TWZsf2f82lzu9COfr+Kyu4xtTU21fXJ0Wt5Ct7tT1667xh+o8hwVKhOTVkHScPafC8/j3JhyFuB9A2WPA2JjrF2Yio77xMw2K+WwUWVWfa7j5KbPG7REIaxEiTDl1PtimfDGFUBQ==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, nd <nd@xxxxxxx>
- Delivery-date: Fri, 31 Jul 2020 12:58:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWZp4EFvxlcjFwoE6yApIOnyEIgKkhpz6A
- Thread-topic: [RESEND][PATCH v2 2/7] xen/arm: kernel: Re-order the includes
> On 30 Jul 2020, at 20:18, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> We usually have xen/ includes first and then asm/. They are also ordered
> alphabetically among themselves.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> ---
> xen/arch/arm/kernel.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index 8eff0748367d..f95fa392af44 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
> @@ -3,20 +3,20 @@
> *
> * Copyright (C) 2011 Citrix Systems, Inc.
> */
> +#include <xen/domain_page.h>
> #include <xen/errno.h>
> +#include <xen/gunzip.h>
> #include <xen/init.h>
> #include <xen/lib.h>
> +#include <xen/libfdt/libfdt.h>
> #include <xen/mm.h>
> -#include <xen/domain_page.h>
> #include <xen/sched.h>
> -#include <asm/byteorder.h>
> -#include <asm/setup.h>
> -#include <xen/libfdt/libfdt.h>
> -#include <xen/gunzip.h>
> #include <xen/vmap.h>
>
> +#include <asm/byteorder.h>
> #include <asm/guest_access.h>
> #include <asm/kernel.h>
> +#include <asm/setup.h>
>
> #define UIMAGE_MAGIC 0x27051956
> #define UIMAGE_NMLEN 32
> --
> 2.17.1
>
>
|
