RE: [PATCH v3] print: introduce a format specifier for pci_sbdf_t

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Sent: 30 July 2020 11:08
> To: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; 
> xen-devel@xxxxxxxxxxxxxxxxxxxx; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Julien 
> Grall <julien@xxxxxxx>;
> Stefano Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Paul 
> Durrant <paul@xxxxxxx>; Kevin
> Tian <kevin.tian@xxxxxxxxx>; Julien Grall <julien.grall@xxxxxxx>
> Subject: Re: [PATCH v3] print: introduce a format specifier for pci_sbdf_t
> 
> On Wed, Jul 29, 2020 at 09:28:53PM +0200, Jan Beulich wrote:
> > On 27.07.2020 12:31, Roger Pau Monne wrote:
> > > The new format specifier is '%pp', and prints a pci_sbdf_t using the
> > > seg:bus:dev.func format. Replace all SBDFs printed using
> > > '%04x:%02x:%02x.%u' to use the new format specifier.
> > >
> > > No functional change intended.
> > >
> > > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> > > Acked-by: Julien Grall <julien.grall@xxxxxxx>
> > > For just the pieces where Jan is the only maintainer:
> > > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> [...]
> > In all reality, Roger, it looks to me as if you should have dropped
> > my ack, as there seems to be nothing left at this point that I'm
> > the only maintainer of.
> 
> Yes, just realized that now, I'm sorry. Your Ack happened before Paul
> became a maintainer of vendor-independent IOMMU code and I completely
> forgot about it.
> 
> I think the overall result of having a modifier for printing SBDFs is
> a win for everyone. TBH I just revived the patch because I think it
> will be helpful to the Arm folks doing the PCI work, if not I wouldn't
> have sent it again.

FWIW I am in favour of change.

  Paul

> 
> Roger.