[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen-netfront: fix potential deadlock in xennet_remove()
On Thu, Jul 23, 2020 at 02:57:22PM -0700, David Miller wrote: > From: Andrea Righi <andrea.righi@xxxxxxxxxxxxx> > Date: Wed, 22 Jul 2020 08:52:11 +0200 > > > +static int xennet_remove(struct xenbus_device *dev) > > +{ > > + struct netfront_info *info = dev_get_drvdata(&dev->dev); > > + > > + dev_dbg(&dev->dev, "%s\n", dev->nodename); > > These kinds of debugging messages provide zero context and are so much > less useful than simply using tracepoints which are more universally > available than printk debugging facilities. > > Please remove all of the dev_dbg() calls from this patch. I didn't add that dev_dbg() call, it's just the old code moved around, but I agree, I'll remove that call and send a new version of this patch. Thanks for looking at it! -Andrea
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |