Re: [PATCH 2/2] tools/ocaml: Default to useful build output

[Christian Lindig <christian.lindig@xxxxxxxxxx>]

________________________________________
From: Elliott Mitchell <ehem+xen@xxxxxxx>
Sent: 18 July 2020 04:32
To: xen-devel@xxxxxxxxxxxxx
Cc: Ian Jackson; wl@xxxxxxx; Christian Lindig; dave@xxxxxxxxxx
Subject: [PATCH 2/2] tools/ocaml: Default to useful build output

While hiding details of build output looks pretty to some, defaulting to
doing so deviates from the rest of Xen.  Switch the OCAML tools to match
everything else.

Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
---

Time for a bit of controversy.

Presently the OCAML tools build mismatches the rest of the Xen build.
My choice is to default to verbose output.  While some may like beauty
in their build output, function is far more important.

If someone wants to take on the task of making Xen's build output
consistently beatiful, invite them to do so.  Then call the police and
tell them you're being robbed.
---
 tools/ocaml/Makefile.rules | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules
index a893c42b43..abfbc64ce0 100644
--- a/tools/ocaml/Makefile.rules
+++ b/tools/ocaml/Makefile.rules
@@ -1,17 +1,20 @@
 ifdef V
-  ifeq ("$(origin V)", "command line")
-    BUILD_VERBOSE = $(V)
-  endif
+       ifeq ("$(origin V)", "command line")
+               BUILD_VERBOSE = $(V)
+       endif
+else
+       V := 1
+       BUILD_VERBOSE := 1
 endif
 ifndef BUILD_VERBOSE
-  BUILD_VERBOSE = 0
+       BUILD_VERBOSE := 0
 endif
 ifeq ($(BUILD_VERBOSE),1)
-  E = @true
-  Q =
+       E := @true
+       Q :=
 else
-  E = @echo
-  Q = @
+       E := @echo
+       Q := @
 endif

 .NOTPARALLEL:
--
2.20.1

-- 
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>