Re: [PATCH 06/12] tools/misc: don't use libxenctrl internals from misc tools

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Ian Jackson writes ("[PATCH 06/12] tools/misc: don't use libxenctrl internals 
from misc tools"):
> From: Juergen Gross <jgross@xxxxxxxx>
> 
> xen-hptool and xen-mfndump are using internals from libxenctrl e.g. by
> including private headers. Fix that by using either the correct
> official headers or use other means.
...
> -        ERROR("Failed to get the maximum mfn");
> +        fprintf(stderr, "Failed to get the maximum mfn");
>          return -1;

I think this is definitely worse than providing a duplicate definition of
ERROR.

Also patches like this are much easier to read if the different kinds
of change are split up.  Do you think you can break it up further ?

Thanks,
Ian.