[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86
- To: "Saheed O. Bolarinwa" <refactormyself@xxxxxxxxx>
- From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
- Date: Mon, 13 Jul 2020 17:01:56 -0500
- Cc: Rich Felker <dalias@xxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-sh@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, Yicong Yang <yangyicong@xxxxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Realtek linux nic maintainers <nic_swsd@xxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linux-i2c@xxxxxxxxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, rfi@xxxxxxxxxxxxxxxxxxxxxx, Toan Le <toan@xxxxxxxxxxxxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxxxxx>, Marek Vasut <marek.vasut+renesas@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, linux-atm-general@xxxxxxxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>, Ley Foon Tan <ley.foon.tan@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Chas Williams <3chas3@xxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Matt Turner <mattst88@xxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx, Kevin Hilman <khilman@xxxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, linux-hwmon@xxxxxxxxxxxxxxx, Jean Delvare <jdelvare@xxxxxxxx>, Andrew Donnellan <ajd@xxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Ray Jui <rjui@xxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, Yue Wang <yue.wang@xxxxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxxxxxxx, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Michael Buesch <m@xxxxxxx>, skhan@xxxxxxxxxxxxxxxxxxx, bjorn@xxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Guan Xuetao <gxt@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Richard Henderson <rth@xxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Scott Branden <sbranden@xxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Jingoo Han <jingoohan1@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Brian King <brking@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, Frederic Barrat <fbarrat@xxxxxxxxxxxxx>, Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>
- Delivery-date: Mon, 13 Jul 2020 22:02:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jul 13, 2020 at 02:22:12PM +0200, Saheed O. Bolarinwa wrote:
> This goal of these series is to move the definition of *all* PCIBIOS* from
> include/linux/pci.h to arch/x86 and limit their use within there.
> All other tree specific definition will be left for intact. Maybe they can
> be renamed.
More comments later, but a few trivial whitespace issues you can clean
up in the meantime. Don't repost for at least a few days to avoid
spamming everybody. I found these with:
$ b4 am -om/ 20200713122247.10985-1-refactormyself@xxxxxxxxx
$ git am
m/20200713_refactormyself_move_all_pcibios_definitions_into_arch_x86.mbx
Applying: atm: Change PCIBIOS_SUCCESSFUL to 0
.git/rebase-apply/patch:11: trailing whitespace.
iadev = INPH_IA_DEV(dev);
.git/rebase-apply/patch:12: trailing whitespace.
for(i=0; i<64; i++)
.git/rebase-apply/patch:13: trailing whitespace.
if ((error = pci_read_config_dword(iadev->pci,
.git/rebase-apply/patch:16: trailing whitespace, space before tab in indent.
return error;
.git/rebase-apply/patch:17: trailing whitespace.
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
Applying: atm: Tidy Success/Failure checks
.git/rebase-apply/patch:13: trailing whitespace.
.git/rebase-apply/patch:14: trailing whitespace.
iadev = INPH_IA_DEV(dev);
.git/rebase-apply/patch:15: trailing whitespace.
for(i=0; i<64; i++)
.git/rebase-apply/patch:21: trailing whitespace.
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
.git/rebase-apply/patch:22: trailing whitespace.
for(i=0; i<64; i++)
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
Applying: atm: Fix Style ERROR- assignment in if condition
.git/rebase-apply/patch:12: trailing whitespace.
unsigned int pci[64];
.git/rebase-apply/patch:13: trailing whitespace.
.git/rebase-apply/patch:14: trailing whitespace.
iadev = INPH_IA_DEV(dev);
.git/rebase-apply/patch:23: trailing whitespace.
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
.git/rebase-apply/patch:32: trailing whitespace.
udelay(5);
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Applying: PCI: Change PCIBIOS_SUCCESSFUL to 0
.git/rebase-apply/patch:37: trailing whitespace.
struct pci_ops apecs_pci_ops =
.git/rebase-apply/patch:50: trailing whitespace.
static int
.git/rebase-apply/patch:59: trailing whitespace.
struct pci_ops cia_pci_ops =
.git/rebase-apply/patch:94: trailing whitespace.
static int
.git/rebase-apply/patch:103: trailing whitespace.
struct pci_ops lca_pci_ops =
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
|