[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/11] common: add vmtrace_pt_size domain parameter
- To: Michał Leszczyński <michal.leszczynski@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Mon, 6 Jul 2020 11:45:58 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, luwei.kang@xxxxxxxxx, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, tamas.lengyel@xxxxxxxxx
- Delivery-date: Mon, 06 Jul 2020 10:46:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 05/07/2020 19:54, Michał Leszczyński wrote:
From: Michal Leszczynski <michal.leszczynski@xxxxxxx>
Add vmtrace_pt_size domain parameter in live domain and
vmtrace_pt_order parameter in xen_domctl_createdomain.
Signed-off-by: Michal Leszczynski <michal.leszczynski@xxxxxxx>
---
xen/common/domain.c | 12 ++++++++++++
xen/include/public/domctl.h | 1 +
xen/include/xen/sched.h | 4 ++++
3 files changed, 17 insertions(+)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index a45cf023f7..25d3359c5b 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -338,6 +338,12 @@ static int sanitise_domain_config(struct
xen_domctl_createdomain *config)
return -EINVAL;
}
+ if ( config->vmtrace_pt_order && !vmtrace_supported )
Looking at the rest of the series, vmtrace will only be supported for
x86 HVM guest. So don't you want to return -EINVAL for PV guests here?
This could be done in a new helper arch_vmtrace_supported() or possibly
in the existing arch_sanitise_domain_config().
Cheers,
--
Julien Grall
|
