[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] scripts: don't rely on "stat -" support
On Thu, Jun 25, 2020 at 11:47 AM Jan Beulich <jbeulich@xxxxxxxx> wrote: > > On 25.06.2020 17:45, Ian Jackson wrote: > > Jan Beulich writes ("[PATCH] scripts: don't rely on "stat -" support"): > >> While commit b72682c602b8 ("scripts: Use stat to check lock claim") > >> validly indicates that stat has gained support for the special "-" > >> command line option in 2009, we should still try to avoid breaking being > >> able to run on even older distros. As it has been determined, contary to > >> the comment in the script using /dev/stdin (/proc/self/fd/$_lockfd) is > >> fine here, as Linux specially treats these /proc inodes. > >> > >> Suggested-by: Ian Jackson <ian.jackson@xxxxxxxxxx> > >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > > > Thanks. > > > > The only code change here is this: > > > >> --- a/tools/hotplug/Linux/locking.sh > >> +++ b/tools/hotplug/Linux/locking.sh > >> @@ -45,18 +45,14 @@ claim_lock() > >> - if stat=$( stat -L -c '%D.%i' - $_lockfile 0<&$_lockfd > >> 2>/dev/null ) > >> + if stat=$( stat -L -c '%D.%i' /dev/stdin $_lockfile 0<&$_lockfd > >> 2>/dev/null ) > > > > Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > > > > Has anyone executed this ? > > I have, of course, to confirm this fixes my issue. But I'm not sure > that's what you've meant to ask - you may have wanted assurance > that someone else has also tried it. Tested-by: Jason Andryuk <jandryuk@xxxxxxxxx> Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |