[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Ping: [PATCH] x86/CPUID: fill all fields in x86_cpuid_policy_fill_native()
(sorry, re-sending with To and Cc corrected) On 22.06.2020 14:39, Andrew Cooper wrote: > On 22/06/2020 13:09, Jan Beulich wrote: >> Coverity validly complains that the new call from >> tools/tests/cpu-policy/test-cpu-policy.c:test_cpuid_current() leaves >> two fields uninitialized, yet they get then consumed by >> x86_cpuid_copy_to_buffer(). (All other present callers of the function >> pass a pointer to a static - and hence initialized - buffer.) >> >> Coverity-ID: 1464809 >> Fixes: c22ced93e167 ("tests/cpu-policy: Confirm that CPUID serialisation is >> sorted") >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> >> >> --- a/xen/lib/x86/cpuid.c >> +++ b/xen/lib/x86/cpuid.c >> @@ -176,6 +176,10 @@ void x86_cpuid_policy_fill_native(struct >> ARRAY_SIZE(p->extd.raw) - 1); ++i ) >> cpuid_leaf(0x80000000 + i, &p->extd.raw[i]); >> >> + /* Don't report leaves from possible lower level hypervisor. */ > > ", for now." > > This will change in the future. > > With this, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Paul? Thanks, Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |