[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.14 v2] x86/tlb: fix assisted flush usage
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Tue, 23 Jun 2020 16:08:06 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, paul@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 23 Jun 2020 15:08:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Roger,
On 23/06/2020 15:50, Roger Pau Monne wrote:
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 9b62087be1..f360166f00 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -639,7 +639,8 @@ static inline void accumulate_tlbflush(bool *need_tlbflush,
}
}
-static inline void filtered_flush_tlb_mask(uint32_t tlbflush_timestamp)
+static inline void filtered_flush_tlb_mask(uint32_t tlbflush_timestamp,
+ bool sync)
I read the commit message and went through the code, but it is still not
clear what "sync" means in a non-architectural way.
As an Arm developper, I would assume this means we don't wait for the
TLB flush to complete. But I am sure this would result to some
unexpected behavior.
So can you explain on non-x86 words what this really mean?
Cheers,
--
Julien Grall
|
