[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] x86/vmx: add IPT cpu feature
- To: Michał Leszczyński <michal.leszczynski@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 22 Jun 2020 14:40:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3n9+xLmlyddooYjRjmoM4rOUfnxJtGQuUXHMaDgnOBg=; b=mHW67qXbr6vcmJbIaByt4SzQ4s9S9vW+avyIR3irvjbsUAM1rzR7kQX1ggJOy6uiZhcX3VLZL/x14TvhDz9OYnRyaRJdhW30A8NrDfOp5AtKOgzOrW3UqXp/nBEucbnm4cHhNa/E1O2CVLeQazbsL2g66q3cxeUlAtJK7T7wzG9KhTQpbSX8Hkm6lYEUAZN6nIn/3jb6cr9cPWpRp5jN/adOYx4dr+koI9Hx+Xz42lbHDJs12YT0RRZvv/WfbCK6U+7BZuf8yFUOcpYPSKrIio1ZDbCscrzAktXuyEfzTsZw1rJA1t2EmPsPQVk/j/lBuvrtPzamLWSc4p51SEskVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AaXf7hNxjE/AdURDa2FUMOdCT4Sn5FBsLjSRQEFDwQ7SYeawh0ByX/nWAp/34vYg4eVITDJLtQxjlQtJo46oYdUGXfXVZZseWN5QCFaUCZWllJ/op4AQ7axyXGSgBnkUIBn/FHAXB6d3qhvIgDOL9Q075qqx7g1EUaWCXW6YZyrYP9SRS1VhOz2ALCPNpJdIs09jPqV3MzDHYrRNst11WtnSIEmgKUZZ+QKHrJjYBCN4k0DG7l3BEncW4D8afGgL7/9k4S7rxvGQboF0ti+0cUWWZi5WqEY6gszLMVcRPulsYLGSN7wBVtK1iQSgx/iHHHf6ABbyEwgweoeeJ1Pw2w==
- Authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, "Kang, Luwei" <luwei.kang@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 22 Jun 2020 12:40:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.06.2020 01:40, Michał Leszczyński wrote:
> @@ -630,6 +633,12 @@ static inline bool hvm_altp2m_supported(void)
> return hvm_funcs.altp2m_supported;
> }
>
> +/* returns true if hardware supports Intel Processor Trace */
> +static inline bool hvm_pt_supported(void)
> +{
> + return hvm_funcs.pt_supported;
> +}
This is vendor-independent code, hence I'd like to see "Intel"
dropped from the comment.
> --- a/xen/include/asm-x86/hvm/vmx/vmcs.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h
> @@ -285,6 +285,7 @@ extern u64 vmx_ept_vpid_cap;
>
> #define VMX_MISC_CR3_TARGET 0x01ff0000
> #define VMX_MISC_VMWRITE_ALL 0x20000000
> +#define VMX_MISC_PT_SUPPORTED 0x00004000
Move this up by two lines, so the values continue to be numerically
sorted?
Jan
|
