RE: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function declarations

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson <ian.jackson@xxxxxxxxxx>
> Sent: 18 June 2020 16:56
> To: Paul Durrant <xadimgnik@xxxxxxxxx>
> Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>; Jason Andryuk 
> <jandryuk@xxxxxxxxx>; Olaf Hering
> <olaf@xxxxxxxxx>; xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>; Wei Liu 
> <wl@xxxxxxx>
> Subject: Re: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function 
> declarations
> 
> Samuel Thibault writes ("Re: [PATCH v1] stubdom/vtpm: add extern to function 
> declarations"):
> > Jason Andryuk, le mer. 17 juin 2020 09:35:52 -0400, a ecrit:
> > > On Wed, Jun 17, 2020 at 2:10 AM Olaf Hering <olaf@xxxxxxxxx> wrote:
> > > >
> > > > Code compiled with gcc10 will not link properly due to multiple 
> > > > definition of the same function.
> > > >
> > > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > >
> > > Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> >
> > Acked-by: Samuel Thibault <samuel.thibaut@xxxxxxxxxxxx>
> 
> Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Thanks.  I have confirmed that these symbols look to be defined (in
> tpm/tpm_emulator_extern.c).  So the patch is correct.
> 
> I think this is 4.14 material.  Paul ?

Agreed.

Release-acked-by: Paul Durrant <paul@xxxxxxx>

> 
> We should also consider it for backports.  How far back do we need
> to go ?
> 
> Ian.