[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/9] tests/cpu-policy: Confirm that CPUID serialisation is sorted


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Mon, 15 Jun 2020 15:52:24 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 15 Jun 2020 14:52:32 +0000
  • Ironport-sdr: u7vFcgU0ZecUN9Y+nU75qkrK6QsHvMYHBHG02UDxLpDm/8PY7vLhfQHCaKFyzsnCEn0dfPcLJ0 v6vuDqkxTss84ZR8uhu3sLB91jgyqzCwXeBQN7H0TeWkPrCYCAqr9ISuFvA60Wgh9KuqQcpMyU rri4OV2+ELAxdZ7dUCkHzm8WkKjuBQpgl3Tx1AG26rU3BmAKJ6ZMl8ol5/x9Ucnfcq7BOTB3FY x5Th+XAi96+WGGrowGc6nStmipmP0esBz5ZKsy8y8n2LtdEGR1ON2U5cgEsM9Zfxpw055WDyNM ilU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Andrew Cooper writes ("[PATCH 2/9] tests/cpu-policy: Confirm that CPUID 
serialisation is sorted"):
> The existing x86_cpuid_copy_to_buffer() does produce sorted results, and we're
> about to start relying on this.  Extend the unit tests.
> 
> As test_cpuid_serialise_success() is a fairly limited set of synthetic
> examples right now, introduce test_cpuid_current() to operate on the full
> policy for the current CPU.
> 
> Tweak the fail() macro to allow for simplified control flow.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I don't think anything in our normal dev workflow runs this
automatically ?  Maybe this would be something for us to think
about...

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.