|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH for-4.13] tools/libxl: Fix memory leak in libxl_cpuid_set()
Andrew Cooper writes ("[PATCH for-4.13] tools/libxl: Fix memory leak in
libxl_cpuid_set()"):
> xc_cpuid_set() returns allocated memory via cpuid_res, which libxl needs to
> free() seeing as it discards the results.
>
> This is logically a backport of c/s b91825f628 "tools/libxc: Drop
> config_transformed parameter from xc_cpuid_set()" but rewritten as one caller
> of xc_cpuid_set() does use returned values.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxx>
>
> Applicable for 4.13 and older.
Thanks. I have committed this to 4.13 and 4.12.
4.12 is no longer supported for bugfixes like this one.
> I'm not going to touch the Ocaml bindings - they're wrong in multiple ways
> including this memory leak, and we deleted them in 4.14 because they were
> totally unused.
That makes sense to me.
Ian.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |