[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH for-4.14] tools: check go compiler version if present
Nick Rosbrook writes ("Re: [PATCH for-4.14] tools: check go compiler version if present"): > > Ideally at some point maybe we would make this clearer but not now. > > Okay, sounds good. > > > Have you tested the situations you describe ? That might be a better > > way of checking that it's right than the code inspection which is > > obviously failing for me now... > > Yes, I have tested the following situations: > > (1) ./configure without go installed => go is not enabled > (2) ./configure with go version < 1.11.1 => go is not enabled > (3) ./configure with go version > 1.11.1 => go is enabled > (4) ./configure --enable-golang without go installed => error > (5) ./configure --enable-golang with go < 1.11.1 => error > (6) ./configure --disable-golang in any case => go is not enabled Thorough! Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Paul, this should go into 4.14. Can I have a release ack plase ? Thanks, Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |