[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

golang bindings dirty in tree after libxl build


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, <rosbrookn@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 12 Jun 2020 12:00:17 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Delivery-date: Fri, 12 Jun 2020 11:00:53 +0000
  • Ironport-sdr: vR9NiALn/RFNcbxQ7REIJJ82GE238rLWs2R/k1YrGceQnb7KWLosRPitTpd+2lEC483fq04PAS XxXyX9838Be2vllZq9TLC+IGzULzUQRPBuI+7I8JP6J/qFnPVENSDO56HcU5FEXxhxvQZEVnUC znYRKR8U41k98YlKMfDaHW6QEXN8jWl3+wqZPXPEaj3MlUw3H7OBs2kyFRVs3+eUS69a3eSzsx opMJWlTRbuOrYJH17LI4ALGlOR9kRuVBGAjck7KwcZuS1MCn8CYvaAovQwMIFsTxETp/Ld5vpb c/s=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hello,

I've just done a libxl build and got things such as:

--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -431,14 +431,14 @@ x.Evtch = int(xc.evtch)
 x.Rref = int(xc.rref)
 x.Connection = ChannelConnection(xc.connection)
 switch x.Connection{
-case ChannelConnectionUnknown:
-x.ConnectionUnion = nil
 case ChannelConnectionPty:
 var connectionPty ChannelinfoConnectionUnionPty
 if err := connectionPty.fromC(xc);err != nil {
  return fmt.Errorf("converting field connectionPty: %v", err)
 }
 x.ConnectionUnion = connectionPty
+case ChannelConnectionUnknown:
+x.ConnectionUnion = nil
 case ChannelConnectionSocket:
 x.ConnectionUnion = nil
 default:

dirty in tree.  They are all case labels, and only their order in the
switch has changed.

Does the current binding generation rely on the order of entries in a
python dictionary by any chance?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.