Re: [PATCH for-4.14] tools: fix error path of xendevicemodel_open()

[Jürgen Groß <jgross@xxxxxxxx>]

On 10.06.20 13:40, Andrew Cooper wrote:
> c/s 6902cb00e03 "tools/libxendevicemodel: extract functions and add a compat
> layer" introduced calls to both xencall_open() and osdep_xendevicemodel_open()
> but failed to fix up the error path.
>
> c/s f68c7c618a3 "libs/devicemodel: free xencall handle in error path in
> _open()" fixed up the xencall_open() aspect of the error path (missing the
> osdep_xendevicemodel_open() aspect), but positioned the xencall_close()
> incorrectly, creating the same pattern proved to be problematic by c/s
> 30a72f02870 "tools: fix error path of xenhypfs_open()".
>
> Reposition xtl_logger_destroy(), and introduce the missing
> osdep_xendevicemodel_close().
>
> Fixes: 6902cb00e03 ("tools/libxendevicemodel: extract functions and add a compat 
> layer")
> Fixes: f68c7c618a3 ("libs/devicemodel: free xencall handle in error path in 
> _open()")
> Backport: 4.9+
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen