Re: [PATCH] x86/boot: use BASEDIR for include path

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/06/2020 17:50, Bertrand Marquis wrote:
> Hi Andrew,
>
>> On 11 Jun 2020, at 17:24, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>
>> On 11/06/2020 12:54, Bertrand Marquis wrote:
>>> Use $(BASEDIR)/include instead of $(XEN_ROOT)/xen/include for the
>>> include path to be coherent with the rest of the Makefiles.
>>>
>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> Does something subtle break before this change?
> Without changing anything no.
> But if xen sub-directory is renamed yes.
>
> As there is no easy way to build xen hypervisor out of tree (I might be wrong 
> here !) I found a solution using cp -rs from xen subdir in a xen-build1 
> xen-build2 etc this way I can check build for x86 and arm without cleaning.
>
> Without the patch, the sources are actually compiles with an include path 
> containing xen/../xen as a result of using XEN_ROOT which does not allow to 
> rename xen subdirectory.
> As it was the only place in which XEN_ROOT was used for include paths, this 
> is normalising the paths.

Ok.  Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

CC Paul for 4.14.

~Andrew