Re: [PATCH v1] kdd: remove zero-length arrays

[Tim Deegan <tim@xxxxxxx>]

Hi,

At 09:55 +0100 on 09 Jun (1591696552), Paul Durrant wrote:
> > -----Original Message-----
> > From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Olaf 
> > Hering
> > Sent: 08 June 2020 21:39
> > To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Olaf Hering <olaf@xxxxxxxxx>; 
> > Tim Deegan <tim@xxxxxxx>;
> > Wei Liu <wl@xxxxxxx>
> > Subject: [PATCH v1] kdd: remove zero-length arrays
> > 
> > Struct 'kdd_hdr' already has a member named 'payload[]' to easily
> > refer to the data after the header.  Remove the payload member from
> > 'kdd_pkt' and always use 'kdd_hdr' to fix the following compile error:
> 
> Is it not sufficient to just change the declaration of payload in kdd_pkt 
> from [0] to []? In fact I can't see any use of the payload
> field in kdd_hdr so it looks like that is the one that ought to be dropped.

Yes, if one of these has to go, it should be the one in the header,
since it's not used and the one in the packet is neatly in the union
with the other decriptions of the packet payload.

I'm not currently in a position to test patches, but might be later in
the week.  Olaf, can you try dropping the 'payload' field from the
header and replacing the payload[0] in pkt with payload[] ?

Cheers,

Tim.