[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Tue, 9 Jun 2020 13:07:36 +0200
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, Sagar Karandikar <sagark@xxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Alistair Francis <Alistair.Francis@xxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Andrzej Zaborowski <balrogg@xxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Alistair Francis <alistair@xxxxxxxxxxxxx>, qemu-arm@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-riscv@xxxxxxxxxx, Stafford Horne <shorne@xxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, "Daniel P . Berrange" <berrange@xxxxxxxxxx>, Thomas Huth <huth@xxxxxxxxxxxxx>, Bastian Koppelmann <kbastian@xxxxxxxxxxxxxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, qemu-ppc@xxxxxxxxxx, Aurelien Jarno <aurelien@xxxxxxxxxxx>
- Delivery-date: Tue, 09 Jun 2020 11:07:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> ---
> hw/input/pckbd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index 60a4130320..c7f42be63b 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -31,7 +31,7 @@
> #include "hw/input/i8042.h"
> #include "sysemu/reset.h"
> #include "sysemu/runstate.h"
> -
> +#include "hw/qdev-deprecated.h"
> #include "trace.h"
>
> /* Keyboard Controller Commands */
> @@ -467,6 +467,8 @@ void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq,
> {
> KBDState *s = g_malloc0(sizeof(KBDState));
>
> + qdev_warn_deprecated_function_used();
> +
> s->irq_kbd = kbd_irq;
> s->irq_mouse = mouse_irq;
> s->mask = mask;
>
Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
The ISA variant is QOM-ified, but you placed the warning in the right place.
Paolo
|
