RE: [PATCH v1] kdd: remove zero-length arrays

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Jürgen Groß <jgross@xxxxxxxx>
> Sent: 09 June 2020 10:06
> To: paul@xxxxxxx; 'Olaf Hering' <olaf@xxxxxxxxx>; 'Paul Durrant' 
> <xadimgnik@xxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; 'Ian Jackson' 
> <ian.jackson@xxxxxxxxxxxxx>; 'Wei Liu' <wl@xxxxxxx>;
> 'Tim Deegan' <tim@xxxxxxx>
> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
> 
> On 09.06.20 11:04, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Olaf Hering <olaf@xxxxxxxxx>
> >> Sent: 09 June 2020 10:00
> >> To: Paul Durrant <xadimgnik@xxxxxxxxx>
> >> Cc: paul@xxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; 'Ian Jackson' 
> >> <ian.jackson@xxxxxxxxxxxxx>; 'Tim
> >> Deegan' <tim@xxxxxxx>; 'Wei Liu' <wl@xxxxxxx>
> >> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
> >>
> >> Am Tue, 9 Jun 2020 09:55:52 +0100
> >> schrieb Paul Durrant <xadimgnik@xxxxxxxxx>:
> >>
> >>> Is it not sufficient to just change the declaration of payload in kdd_pkt 
> >>> from [0] to []?
> >>
> >> AFAIR this lead to compile errors.
> >>
> >
> > OOI which compiler (might be worth mentioning in the commit comment too, 
> > for reference)? I'm not
> seeing a problem.
> 
> We don't use array[] in public headers, but AFAIK using them internally
> is fine.
> 

Yeah, we have XEN_FLEX_ARRAY_DIM for public headers.

  Paul

> 
> Juergen