[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering



On 08/06/2020 14:41, Jan Beulich wrote:
> On 08.06.2020 15:34, Andrew Cooper wrote:
>> The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a
>> while.  commitish_version() pulls an old version of xen/Makefile out of
>> history, and uses the xenversion rule.
>>
>> Currently, this fails with:
>>
>>   tmp.support-matrix.xen.make:130: scripts/Kbuild.include: No such file or 
>> directory
>>
>> which is because the Makefile legitimately references Kbuild.include with a
>> relative rather than absolute path.
>>
>> Rework support-matrix-generate to use sed to extract the major/minor, rather
>> than expecting xen/Makefile to be usable in a different tree.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
>> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Julien Grall <julien@xxxxxxx>
>> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> CC: Paul Durrant <paul@xxxxxxx>
>>
>> v2:
>>  * Use sed rather than fixing up the makefile environment
>>
>> This needs backporting to all trees with the support matrix logic, to unbreak
>> docs rendering
> Did I understand the earlier discussion wrong then that the breakage
> was connected to the introduction of xen/scripts/Kbuild.include?

The xendocs cron email has been broken for an unknown period of time,
hence the issue going unnoticed.

The first of at least 3 breakages in the current docs rendering
manifests like this.

It may be that xen/scripts/Kbuild.include was the first thing to
actually break this script, but I haven't checked, and its not relevant
to the fragility of the old logic.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.