Re: [PATCH-for-4.14 1/2] xen: fix build with CONFIG_HYPFS_CONFIG enabled

[Jürgen Groß <jgross@xxxxxxxx>]

On 02.06.20 14:07, Wei Liu wrote:
> On Tue, Jun 02, 2020 at 01:55:14PM +0200, Jan Beulich wrote:
> > On 02.06.2020 13:40, Juergen Gross wrote:
> > > --- a/xen/common/Makefile
> > > +++ b/xen/common/Makefile
> > > @@ -75,7 +75,7 @@ obj-$(CONFIG_UBSAN) += ubsan/
> > >   obj-$(CONFIG_NEEDS_LIBELF) += libelf/
> > >   obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/
> > >   
> > > -config.gz: ../.config
> > > +config.gz: $(XEN_ROOT)/xen/$(KCONFIG_CONFIG)
> > Looking at all pre-existing uses of KCONFIG_CONFIG this is the
> > first one assuming it holds a relative path. The doc also doesn't
> > indicate it can't be an absolute one.
> This is not an objection to this patch right?
I can see his point.

In case KCONFIG_CONFIG is set to an absolute path the result won't
build.

The proper solution would be to test KCONFIG_CONFIG for being an
absolute path and do the prefixing of $(XEN_ROOT)/xen/ only if this
isn't the case.

I'll send V2 of this patch.


Juergen