RE: [PATCH v2 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@xxxxxxxxx> On Behalf Of 
> Philippe Mathieu-Daudé
> Sent: 01 June 2020 15:29
> To: qemu-devel@xxxxxxxxxx
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Anthony Perard 
> <anthony.perard@xxxxxxxxxx>; Paolo Bonzini
> <pbonzini@xxxxxxxxxx>; Hervé Poussineau <hpoussin@xxxxxxxxxxx>; Helge Deller 
> <deller@xxxxxx>; qemu-
> arm@xxxxxxxxxx; Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>; Stefano 
> Stabellini
> <sstabellini@xxxxxxxxxx>; Michael S. Tsirkin <mst@xxxxxxxxxx>; Eduardo 
> Habkost <ehabkost@xxxxxxxxxx>;
> Paul Durrant <paul@xxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>; 
> qemu-trivial@xxxxxxxxxx; Peter Maydell
> <peter.maydell@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Cédric Le Goater 
> <clg@xxxxxxxx>; qemu-
> ppc@xxxxxxxxxx; Richard Henderson <rth@xxxxxxxxxxx>; Philippe Mathieu-Daudé 
> <f4bug@xxxxxxxxx>
> Subject: [PATCH v2 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix 
> definitions
> 
> IEC binary prefixes ease code review: the unit is explicit.
> 
> Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>

Reviewed-by: Paul Durrant <paul@xxxxxxx>

> ---
>  hw/i386/xen/xen-hvm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index 82ece6b9e7..94fe5d65e9 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -9,6 +9,7 @@
>   */
> 
>  #include "qemu/osdep.h"
> +#include "qemu/units.h"
> 
>  #include "cpu.h"
>  #include "hw/pci/pci.h"
> @@ -230,7 +231,7 @@ static void xen_ram_init(PCMachineState *pcms,
>           * Xen does not allocate the memory continuously, it keeps a
>           * hole of the size computed above or passed in.
>           */
> -        block_len = (1ULL << 32) + x86ms->above_4g_mem_size;
> +        block_len = (4 * GiB) + x86ms->above_4g_mem_size;
>      }
>      memory_region_init_ram(&ram_memory, NULL, "xen.ram", block_len,
>                             &error_fatal);
> --
> 2.21.3