Re: [PATCH v7 03/12] docs: add feature document for Xen hypervisor sysfs-like support

[Jürgen Groß <jgross@xxxxxxxx>]

On 27.04.20 15:55, George Dunlap wrote:
> > On Apr 2, 2020, at 4:46 PM, Juergen Gross <JGross@xxxxxxxx> wrote:
> [snip]
> > +* {VALUE, VALUE, ... } -- a list of possible values separated by "," and
> > +  enclosed in "{" and "}".
> [snip]
> > +So an entry could look like this:
> > +
> > +    /cpu-bugs/active-pv/xpti = ("No"|{"dom0", "domU", "PCID on"}) [w,X86,PV]
> > +
> > +Possible values would be "No" or a list of "dom0", "domU", and "PCID on".
> One thing that wasn’t clear to me here:  Does the “list” look like
>
>      “dom0", “domU", “PCID on”
>
> or
>
>      {dom0, domU, PCID on}
>
> or
>
>      {“dom0”, “domU”, “PCID on”}
>
> ?
This is only the notation used.

The entry could then be e.g.

  dom0 domU

> Another question that occurs to me from asking this question: in a case like this, are we 
> generally expecting to have options with spaces in them (like “PCID on”)? 
> And/or, are we expecting the strings themselves to have quotes in them? If so, commands to 
> manipulate these will start to look a little gnarly:
>
>      xenhypfs write <path> “{\”dom0\”, \”PCID on\”}”
You've got a point here. Spaces in single items seem to be a bad idea,
especially in lists.

And as said above: the '{', ',' and the quotes are notation only, they
are not part of the entry content.

> It seems like it would be nicer to be able to write:
>
>      xenhypfs write <path> "{dom0, PCID-on}”
This would be then:

  xenhypfs write <path> "dom0 PCID-on"

> (Maybe this will be made more clear later in the series, just thought I’d share 
> my thoughts / confusion here.)
I'll make this clearer.


Juergen