[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] x86: validate VM assist value in arch_set_info_guest()

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Mon, 20 Apr 2020 21:16:45 +0100
Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
Delivery-date: Mon, 20 Apr 2020 20:16:52 +0000
Ironport-sdr: 5KlfpzTaGjUzWPOT65dlL7Y6WTJEUFvOea1IHb3rOvn2o0FsGfEzRDT3iFD0ONEJ1t+7nMbHbi 663pp4va7LGdFQ16w8xylAXjEwYHFvmKnegfdIEmX9yZqYtNiOkV74YITzScfhPeMDPcZyZIZP DkIkXYdm51gw+NpFlNZCz09NU8VaVxu37NgeHV70P2pslWwHe/RhpSL6vVP81LFg7SJxAI/I/3 RNSLAr6HOhPWCPzMLG4jzyE/ZMIlzZYuNsPsvT+Mpie8d0uvYau1dAoiP82Fy/Q39oAlbSNHch b5E=
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/04/2020 12:35, Jan Beulich wrote:
> While I can't spot anything that would go wrong, just like the
> respective hypercall only permits applicable bits to be set, we should
> also do so when loading guest context.
>
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

References:
- [PATCH v2 0/2] x86: VM assist hypercall adjustments
  - From: Jan Beulich
- [PATCH v2 2/2] x86: validate VM assist value in arch_set_info_guest()
  - From: Jan Beulich

Prev by Date: Re: [PATCH v2 1/2] x86/HVM: expose VM assist hypercall
Next by Date: grant_table_op v2 support for HVM?
Previous by thread: [PATCH v2 2/2] x86: validate VM assist value in arch_set_info_guest()
Next by thread: [PATCH v6 00/10] x86emul: further work
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.