[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] x86/ucode: Simplify the ops->collect_cpu_info() API

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: Jan Beulich <jbeulich@xxxxxxxx>
Date: Fri, 3 Apr 2020 15:46:18 +0200
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
Delivery-date: Fri, 03 Apr 2020 13:46:24 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.04.2020 12:19, Andrew Cooper wrote:
> All callers pass &this_cpu(cpu_sig) for the cpu_sig parameter, and all
> implementations unconditionally return 0.  Simplify it to be void.
> 
> Drop the long-stale comment on the AMD side, whose counterpart in
> start_update() used to be "collect_cpu_info() doesn't fail so we're fine".
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

References:
- [PATCH 0/5] x86/ucode: Cleanup part 5/n
  - From: Andrew Cooper
- [PATCH 5/5] x86/ucode: Simplify the ops->collect_cpu_info() API
  - From: Andrew Cooper

Prev by Date: Re: [PATCH 4/5] x86/ucode: Drop ops->free_patch()
Next by Date: RE: [PATCH] docs: Render .md files using pandoc
Previous by thread: [PATCH 5/5] x86/ucode: Simplify the ops->collect_cpu_info() API
Next by thread: [PATCH 3/5] x86/ucode: Don't try to cope with NULL pointers in apply_microcode()
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.