[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string
- To: Julien Grall <julien@xxxxxxx>
- From: Ian Jackson <ian.jackson@xxxxxxxxxx>
- Date: Tue, 31 Mar 2020 12:17:51 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "dfaggioli@xxxxxxxx" <dfaggioli@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 31 Mar 2020 11:18:00 +0000
- Ironport-sdr: 12Nf3kBLyFSN81od+sOi+N/4226yO86rD9RYADvPCXr91ajDueicon0aPsltuzHD3CatEDxWz/ J8iwnhs+q9TBEMRjiw7zHmz8tqop72xUs4r54iIYsrbQRwLoqS4Ye+CKngnzvPoXFPUrbO1s53 eMuU6og/AYVykUMTgTxzs/JE34jEKDQK+zX7A1rGtivqybIK6+TUno5Hj05q2bWCulDy/lGUxG lOYX4UvXIpLFrAjIn40FJ5AeNz0v6vkGMftoozgNufrkidIH9eIjY+76dkA3HRAr2eVRaVYl+o Mes=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Julien Grall writes ("[PATCH 0/8] Fix build with using OCaml 4.06.1 and
-safe-string"):
> This series is meant to solve the build issue reported by Dario when
> using recent version of OCaml and -safe-string.
Thanks. I have reviewed the C tools parts here. I think the ocaml
parts ought to have a review from someone familiar with the ocaml FFI.
> I took the opportunity to harden a bit more the code by using const more
> often.
I approve.
Perhaps we should start building our C code with -Wwrite-strings,
which makes "" have type const char* ? Result would be a giant
constification patch, probably.
Ian.
|