[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: x86: make init_intel_cacheinfo() void.

On 26/03/2020 17:17, Dario Faggioli wrote:
> It seems that we took this code from Linux, back when the function was
> 'unsigned int' and the return value was used.
> But we are currently not doing anything with such value, so let's get
> rid of it and make the function void. As an anecdote, that's pretty much
> the same that happened in Linux as, since commit 807e9bc8e2fe6 ("x86/CPU:
> Move cpu_detect_cache_sizes() into init_intel_cacheinfo()") the function
> is void there too.
> Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Furthermore, Shanghai already uses this in its form.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.