[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/7] x86/ucode/intel: Clean up microcode_sanity_check()

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 26 Mar 2020 14:41:27 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 26 Mar 2020 14:41:40 +0000
  • Ironport-sdr: aFFSIL/ZV3a/MyAQC9Oc+Eh/v0KjiPlHo64AQrL5M+EjDiI6LzgXOluhvhE1rM9ltKCk+qamKg bfWRxX22eM2naUUJFTc/8m1MH/bhrErmYmsr9MkBfzoxauaY2Cpv2QgJ+5qCQ+O86dlbiQvmje JoghcdUBop57O3lskbtb6qJABjUdTJQRley6Vanutv+Ean3718pmfNyfvVjAOJl+JoUHCxouJG l9qcFOtgdKkaAJydVHjb12ILk7LwDvUJNFSDSEwPmMA/RaugRjyVuaQHPg0sUew3MZL48qx3oM S7M=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25/03/2020 14:07, Jan Beulich wrote:
>> Introduce a check missing from the old code, that total_size is a multiple of
>> 1024 bytes,
> Where is this documented? The rather brief section in SDM vol 3 doesn't
> mention anything like this.

It is in the middle of the final paragraph of 9.11.1 Microcode Update,
immediately preceding Table 9-7

"The total size field of the microcode update header specifies the
encrypted data size plus the header size; its value must be in multiples
of 1024 bytes (1 KBytes)."


(I've lost count of how many times I've read this chapter over the
course of developing this series...)



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.