[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] x86/nvmx: update exit bitmap on vmexit


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Tue, 24 Mar 2020 10:16:52 +0000
  • Accept-language: en-US
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 24 Mar 2020 10:17:07 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version: 11.2.0.6
  • Ironport-sdr: fVbF5/1/LG06lue83jGkbNwvDE2cTFh/9cJLTJdXv/GE2aDq+nOa+rj6TXjiZ17wIkAkBzNruZ sLuExEqhEXkg==
  • Ironport-sdr: psZ8DdNBeBmB1REW/d7ZuNKbZ4s/P0tW2Iv3QCBFJGWDB2NbGcjbhICfOHIWIg0Og7UVYs6JeD viEdpWBzadMg==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHV/urpfF5j4vGzhUi/L3UBZDzwCKhXRtFA//+6/YCAAImY0A==
  • Thread-topic: [PATCH 3/3] x86/nvmx: update exit bitmap on vmexit

> From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Sent: Tuesday, March 24, 2020 5:59 PM
> 
> On Tue, Mar 24, 2020 at 06:22:43AM +0000, Tian, Kevin wrote:
> > > From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > > Sent: Saturday, March 21, 2020 3:08 AM
> > >
> > > Current code in nvmx_update_apicv set the guest interrupt status field
> > > but doesn't update the exit bitmap, which can cause issues of lost
> > > interrupts on the L1 hypervisor if vmx_intr_assist gets
> > > short-circuited by nvmx_intr_intercept returning true.
> >
> > Above is not accurate. Currently Xen didn't choose to update the EOI
> > exit bitmap every time when there is a change. Instead, it chose to
> > batch the update before resuming to the guest. sort of optimization.
> > So it is not related to whether SVI is changed. We should always do the
> > bitmap update in nvmx_update_apicv, regardless of the setting of
> > Ack-on-exit ...
> 
> But if Ack on exit is not set the GUEST_INTR_STATUS won't be changed
> by nvmx_intr_intercept, and hence there's no need to update the EOI
> exit map?
> 
> If OTOH the GUEST_INTR_STATUS field is changed by vmx_intr_assist the
> bitmap will already be updated there.
> 

If you agree with my comment in patch 2/3 about setting RVI for 
ack-on-exit=0, then EOI bitmap update should be done there too.

Thanks
Kevin

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.