Re: [Xen-devel] [PATCH] tools/xenstore: don't close connection in xs_talkv()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/03/2020 15:44, Andrew Cooper wrote:
> On 23/03/2020 14:29, Juergen Gross wrote:
>> In case of some errors xs_talkv() will close the connection to
>> Xenstore. This is annoying as it is not clear to the caller in which
>> error case the connection is still available.
>>
>> Drop that implicit closing to make the interface behave in a sane and
>> predictable way.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> This definitely does improve the cascade failure cases.
>

Actually, I spoke too soon.  The EBADF goes, but the next read_message()
ends up pulling junk out of the ring.

I think something else in the middle needs teaching about hard errors,
and not to pull more data out of the ring.

~Andrew