[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

Hi Juergen & Jan,

On 26/02/2020 12:47, Juergen Gross wrote:
diff --git a/docs/misc/hypfs-paths.pandoc b/docs/misc/hypfs-paths.pandoc
index 1faebcccbc..b4a5b6086e 100644
--- a/docs/misc/hypfs-paths.pandoc
+++ b/docs/misc/hypfs-paths.pandoc
@@ -152,3 +152,12 @@ The major version of Xen.
  #### /buildinfo/version/minor = INTEGER
The minor version of Xen.
+#### /params/
+A directory of runtime parameters.
+#### /params/*
+The individual parameters. The description of the different parameters can be
+found in `docs/misc/xen-command-line.pandoc`.
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index a497f6a48d..0061a8dfea 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -89,6 +89,11 @@ SECTIONS
         __start_schedulers_array = .;
         __end_schedulers_array = .;
+       . = ALIGN(8);

Apologies for the late answer. I noticed that Jan asked the following question on v5:

"Do you really need 8-byte alignment even on 32-bit Arm?"

We forbid unaligned access on 32-bit Arm (and unaligned access should be avoided on 64-bit), so if the structure contains a 64-bit type, then we definitely need the data to be 8-byte aligned.

What is the expected alignment of the structure?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.