Re: [Xen-devel] [PATCH 2/4] x86/ucode: Fix error paths in apply_microcode()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 20.03.2020 22:24, Andrew Cooper wrote:
> @@ -259,15 +260,14 @@ static int apply_microcode(const struct microcode_patch 
> *patch)
>      /* check current patch id and patch's id for match */
>      if ( hw_err || (rev != hdr->patch_id) )
>      {
> -        printk(KERN_ERR "microcode: CPU%d update from revision "
> -               "%#x to %#x failed\n", cpu, rev, hdr->patch_id);
> +        printk(XENLOG_ERR
> +               "microcode: CPU%u update rev %#x to %#x failed, result %#x\n",
> +               cpu, old_rev, hdr->patch_id, rev);
>          return -EIO;
>      }
>  
> -    printk(KERN_WARNING "microcode: CPU%d updated from revision %#x to 
> %#x\n",
> -           cpu, sig->rev, hdr->patch_id);
> -
> -    sig->rev = rev;
> +    printk(XENLOG_WARNING "microcode: CPU%u updated from revision %#x to 
> %#x\n",
> +           cpu, old_rev, hdr->patch_id);

Prefer the local variable here over hdr->patch_id, just like you do
on the Intel side?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel