[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/6] x86/ucode: Rationalise startup and family/model checks

On 19.03.2020 16:26, Andrew Cooper wrote:
> Drop microcode_init_{intel,amd}(), export {intel,amd}_ucode_ops, and use a
> switch statement in early_microcode_init() rather than probing each vendor in
> turn.  This allows the microcode_ops pointer to become local to core.c.
> As there are no external users of microcode_ops, there is no need for
> collect_cpu_info() to implement sanity checks.  Move applicable checks to
> early_microcode_init() so they are performed once, rather than repeatedly.
> Items to note:
>  * The AMD ucode driver does have an upper familiy limit of 0x17, as a side
>    effect of the logic in verify_patch_size() which does need updating for
>    each new model.

I don't see this being the case, and hence I think it is this patch
which introduces such a restriction. As long a patches are less
than 2k, all unspecified families are supported by verify_patch_size()
through its default: case label. (Arguably the name F1XH_MPB_MAX_SIZE
doesn't really fit how it is being used.)

I'm happy about all other changes made here.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.