Re: [Xen-devel] [PATCH 2/2] tools/xenstore: Accumulate errors in xenstore-ls and exit appropriately

[David Woodhouse <dwmw2@xxxxxxxxxxxxx>]

On Fri, 2020-03-20 at 11:03 +0000, Paul Durrant wrote:
> > +                val = NULL;
> > +                /* Don't repeat an error message if xs_read() already 
> > failed */
> > +                if (val)
> 
> How can the code get here? The line above the comment always sets val to NULL.

Oops, I don't think it was supposed to. It was just stray testing which
I neglected to remove.

Will repost with that fixed, if that's the way we want to go.

It's patch 1 which I really care about; this part is just yak shaving
at Ian's prompting.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel