[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

On Wed, Mar 18, 2020 at 11:46:06AM +0000, David Woodhouse wrote:
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Remove a ternary operator that made my brain hurt.
> Replace it with something simpler that makes it somewhat clearer that
> the check for initrdidx < mbi->mods_count is because larger values are
> what find_first_bit() will return when it doesn't find anything.
> Also drop the explicit check for module #0 since that would be the
> dom0 kernel and the corresponding bit is always clear in module_map.
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Acked-by: Julien Grall <julien@xxxxxxx>

Reviewed-by: Wei Liu <wl@xxxxxxx>

I think this is a fine improvement. It is more straightforward to


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.