Re: [Xen-devel] [PATCH] xen/x86: Move microcode into its own directory

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/03/2020 09:21, Jan Beulich wrote:
> On 18.03.2020 22:05, Andrew Cooper wrote:
>> Split the existing asm/microcode.h in half, keeping the per-cpu cpu_sig
>> available to external users, and moving everything else into private.h
>>
>> Take the opportunity to trim and clean up the include lists for all 3 source
>> files, all of which include rather more than necessary.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit preferably with ...
>
>> ---
>>  xen/arch/x86/Makefile                              |  4 +--
>>  xen/arch/x86/microcode/Makefile                    |  3 ++
>>  xen/arch/x86/{microcode_amd.c => microcode/amd.c}  | 12 ++++----
>>  xen/arch/x86/{microcode.c => microcode/core.c}     | 15 +++-------
>>  .../x86/{microcode_intel.c => microcode/intel.c}   |  9 ++----
>>  .../microcode.h => arch/x86/microcode/private.h}   | 19 ++++---------
> ... these going into xen/arch/x86/cpu/microcode/. Thoughts?

TBH, I've always found the cpu/ directory redundant.  Everything in
arch/x86 is part of the CPU, and these days, even drivers/passthrough is
part of the CPU.

I'm happy to put it wherever makes sense, so long as there is a clear
understanding of why.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel