[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Mar 2020 11:20:44 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qzwy+/6WjmvFeqvwH006gCRzGb6dSQBcl0noLPZMSlw=; b=I2t5ho4puen4A2npp6bc+5CjuuJXUUe/2ranIiftoYTtRGKcwL2uJUKdKizMoUCRmIl0UcMJwkCqy0qWR98o41B7GHOBymWMHcmTuip0zEpNX+9T8o/H9iPAa8oLwTUoHj7TeEKs6BZD3PIb17WoJNrxf6pIzBGlr/PBCZtfSwPuZACxoltYe9f/Q/hxo5dKmPgkvo75CWFrBt4KIFVjEzXNpX2q7TuzK1bJBmxxsGvdwnFs69Gvyc7zpx8/x9eyvgOBFYH5/Zd9uRsaAuVdmDcExHrT5hfPzpYrcktfVWOByKn2qn7icAz9XXJdiFoz/P94gGT5fw3qcdxlzXUdXA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4f8S6wA8/+nwcN5u2MKyhsCXu2nS4jZ0PDXDXDOlY3FT3QPsctywr8rPUV11lxcxxwmJqkZDvLIvDReZVGP5wAoN6Cx3QRvkZCzkIxwKb59aYGP+mzSxBAlRgxvKcpXG+oKE3o2AZs5A6dqUOMiUpxg58D5DCeABMQh/09Wx30LQ3dEFqELd0aM5IttvMdH+qkawktyJNS+ainfViXoFlYqFPL+w/aF1C0Qanj60cuBB5WqzU7Jd1x9UVKkBzPjbPeIaO1BzrFZkrNl9bfrujGCXxkiZguDumvxhBImauI1Ogs1FwCRJpzmg42g+qehQ+ZZvMke2CdQuVwWSRFAXg==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Mar 2020 10:30:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.03.2020 19:35, Anthony PERARD wrote:
On Wed, Mar 04, 2020 at 04:00:52PM +0100, Jan Beulich wrote:
On 26.02.2020 12:33, Anthony PERARD wrote:
@@ -113,6 +115,64 @@ $(KCONFIG_CONFIG):

I can't seem to be able to spot a similar line for AFLAGS.

I didn't add any because it wasn't necessary.

Symmetry / consistency would still be desirable imo.

@@ -107,7 +65,7 @@ $(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) 
$(extra-y)),$(eval $(call gend
  subdir-y := $(subdir-y) $(filter %/, $(obj-y))
  obj-y    := $(patsubst %/, %/built_in.o, $(obj-y))
-$(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += -DINIT_SECTIONS_ONLY
+$(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS-y += 

While in the description you say "We can't use CFLAGS in
subdirectories to add flags to particular targets, ...", it
remains unclear there why that is, and hence why changes like
this one are necessary. If this is a restriction that's going to
remain, this also needs writing down in a prominent place. After

Yes, I should probably start writing some documentation, probably
following the kind of documentation that Linux has for kbuild, and I
could put that in docs/misc, along side the kconfig doc. That probably
not a prominent place, but I don't know if there's a better place.

If it's to live under docs/, then I guess xen/Rules.mk should at
least point to that documentation (perhaps in a comment near the
first setting or consumption of CFLAGS-y).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.