[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 00/11] error: auto propagated local_err part I

  • To: Markus Armbruster <armbru@xxxxxxxxxx>
  • From: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx>
  • Date: Tue, 17 Mar 2020 12:42:07 +0300
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXIrKZnGV8uShkz+6JSMur7bn9zGmhlSZt9rYDbIgqQ=; b=HJDjvra/ik7PtXNdueI0PxUXUowO3zVFSA3PNlasvYb6RPPCjhDUtxYiHLX0KlrlfT+ERQiQZsfStP42AbkMoAoTKr6qSmTf80c//FZz05MgySIsxAjM4Xb0PYXCy9AjXjOVl7vCvjoVMHADEdvCFwB5QQCCsi8Xj6DhpzXcLNfoDM3c2ayFl/rAHgX4O6c9jFtUqDfeqNjYZ0xZ7JRbbwkwbAtNCsiy7n4h/6B5GVwGcswhMPtSTnPM7Y3IwB2q440qQdP5zr5fh+10mBkMKlXp0BBmM2Fj1skj6QQdc7Vv9KsfhWwKLwC/1mnhIuK/RjSf66VN19aBquG7FOkeRQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XAGm3p5h/c3Jn6E0T/QthJNOPoCtdBmdPNukned8O8AnG1HjRf8c2vd1+k8viDFfJRjXnnuH2ejnOyUwHvnpmkgRJ/7VOUd/yIl8vHo7hHwcW89xCWLz4Gh8VKHOJdU4CGE1Bj/d7J3WIY1ebvYiJ6VTi1KjeeSdXVhOrIQ4VAwKD24ybdi+HWqjidOxopaZdalHQk9mt5AgQgoaPHr876OVT9/mifPebuRE2OnyPyD9ZDV6KwRHi6ALKi3Ow38taVmuIynwBii4Yt8nbfCzB6Py3eriE6xWgtsz+gvBzGFxL6C/g8iPIE5H75/qOleEG8RIJ2UOd6epr+OGGVmJPQ==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vsementsov@xxxxxxxxxxxxx;
  • Cc: Kevin Wolf <kwolf@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Greg Kurz <groug@xxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Max Reitz <mreitz@xxxxxxxxxx>, Laszlo Ersek <lersek@xxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 17 Mar 2020 09:42:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

16.03.2020 17:40, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx> writes:

03.03.2020 11:01, Markus Armbruster wrote:
Hi Vladimir,

I've come to rather like your ERRP_AUTO_PROPAGATE() idea.  What I
wouldn't like is a protracted conversion.

Once we're happy with PATCH 1-3, it's a matter of running Coccinelle and
reviewing its output.  I'm confident we can converge on PATCH 1-3.

It's two weeks until soft freeze.  We need to decide whether to pursue a
partial conversion for 5.0 (basically this series plus the two patches
we identified in review of PATCH 1), or delay until 5.1.  In either
case, I want the conversion to be finished in 5.1.

Please do not feel pressured to make the 5.0 deadline.

I can queue up patches for 5.1 during the freeze.

How would you like to proceed?

Hi Markus! Funny coincidence: exactly now (less than 1 hour ago), I've
started working for the next version for these series. So, I'm going to
resend today. Of course, I'd prefer to merge something to 5.0 if at all

That was v8, followed by v9.  We're clearly converging.  However, the
soft freeze is tomorrow already.

You've persevered with this idea for quite a while; some impatience
would be quite excusable now.  Still, I doubt part I making 5.0 matters.

Not a problem. I hope, I'll resend soon, then it will be up to you.

The hand-written part is likely to rebase easily, and the generated part
should be regenerated instead of rebased anyway.

What actually matters is *finishing* the job.  What does that take?

* Consensus on the hand-written part.  I think we're basically there, we
   just want to work in a few more tweaks.

I'll resend today, most probably it would be your version of coccinelle (if I 
will not find real sense in fn inheritance).

* Split the generated part into reviewable batches, regenerating patches
   as necessary.  Solicit review.  First batch is part of this series,
   and v9 looks ready to me.  I assume you'll prepare the remaining

Yes I will. This is the reward for this work: send one hundred generated 
patches :))

* Queue up batches as they become ready, post pull requests.  I can do

* Update the QAPI code generator to the new Error usage.  I can do that.


Best regards,

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.