Re: [Xen-devel] [PATCH] x86/HVM: fix AMD ECS handling for Fam 10

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/03/2020 11:00, Jan Beulich wrote:
> The involved comparison was, very likely inadvertently, converted from
>> = to > when making changes unrelated to the actual family range.
> 
> Fixes: 9841eb71ea87 ("x86/cpuid: Drop a guests cached x86 family and model 
> information")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> 
> --- a/xen/arch/x86/hvm/ioreq.c
> +++ b/xen/arch/x86/hvm/ioreq.c
> @@ -1284,7 +1284,7 @@ struct hvm_ioreq_server *hvm_select_iore
>          if ( CF8_ADDR_HI(cf8) &&
>               d->arch.cpuid->x86_vendor == X86_VENDOR_AMD &&
>               (x86_fam = get_cpu_family(
> -                 d->arch.cpuid->basic.raw_fms, NULL, NULL)) > 0x10 &&
> +                 d->arch.cpuid->basic.raw_fms, NULL, NULL)) >= 0x10 &&
>               x86_fam < 0x17 )
>          {
>              uint64_t msr_val;
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel